Skip to content

Feature/lin 55 comment first mode#158

Open
fs21co049adityawaghule wants to merge 7 commits into
mainfrom
feature/LIN-55-comment-first-mode
Open

Feature/lin 55 comment first mode#158
fs21co049adityawaghule wants to merge 7 commits into
mainfrom
feature/LIN-55-comment-first-mode

Conversation

@fs21co049adityawaghule
Copy link
Copy Markdown
Contributor

Linear Issue

Closes LIN-XXX (or Relates to LIN-XXX)

Changes

  • Change 1: Description
  • Change 2: Description
  • Change 3: Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • ♻️ Code refactoring
  • ⚡ Performance improvement
  • 🧪 Test updates

Testing

  • Tested locally (describe steps)
  • Unit tests pass: npm run test:unit
  • Integration tests pass: npm run test:integration
  • E2E tests pass (if applicable): npm run test:e2e
  • Manual testing done

Test Coverage

Coverage: XX% (target: 80% for services, 70% for API routes)

Screenshots / Videos

Security Considerations

  • No secrets or PII logged
  • Workspace isolation maintained in all DB queries
  • Input validation added (Zod schemas)
  • No hardcoded credentials
  • Rate limiting considered
  • Encryption used for sensitive data

Documentation

  • AGENTS.md updated (if patterns changed)
  • docs/API.md updated (if endpoints changed)
  • docs/DECISIONS.md updated (if architectural decision)
  • README.md updated (if user-facing changes)
  • CHANGELOG.md updated
  • Comments added to complex code

Database Changes

  • Migration file created: npx prisma migrate dev --name descriptive_name
  • Migration tested locally
  • No breaking changes (or documented)
  • Rollback plan considered

API Changes

  • Backward compatible
  • New endpoints documented in docs/API.md
  • Request/response examples provided
  • Error handling documented

Deployment Notes

  • Environment variables added (document in .env.example)
  • Feature flags configured (if applicable)
  • Database migration required
  • Cache invalidation needed
  • Third-party service configuration updated

Pre-PR Checklist

  • Read AGENTS.md
  • Branch named correctly: feature/LIN-XXX-description
  • Commits follow format: LIN-XXX: Description
  • git pull origin main done (no conflicts)
  • npm run lint passes
  • npm run typecheck passes
  • npm run test passes
  • No console.log or debugger statements
  • Code reviewed by yourself first
  • PR size reasonable (<500 lines, or justified)

Reviewer Notes

Related PRs

Post-Merge Actions

  • Deploy to staging
  • Update Linear issue status
  • Notify team in Slack
  • Update documentation site (if applicable)
  • Monitor error rates after deployment

Screenshots of Changes


By submitting this PR, I confirm that:

  1. I have read and followed the guidelines in AGENTS.md
  2. My changes follow the code style of this project
  3. I have performed a self-review of my code
  4. I have made corresponding changes to the documentation
  5. My changes generate no new warnings
  6. I have added tests that prove my fix is effective or my feature works
  7. New and existing unit tests pass locally with my changes
  8. Any dependent changes have been merged and published

Aditya and others added 7 commits February 18, 2026 14:51
- Added workspaceId to all analytics functions (funnel.ts, validation.ts)
- All SQL queries now scoped by workspace_id
- Added date validation via resolveDateRange (returns 400 on invalid)
- Routes pass session.workspaceId to analytics functions
- Enforced ordered stage progression in funnel paths
- Resolved conflicts with origin/feature/LIN-55-comment-first-mode
- Kept ttfv functionality and dateRange tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants