Feature/lin 55 comment first mode#158
Open
fs21co049adityawaghule wants to merge 7 commits into
Open
Conversation
- Added workspaceId to all analytics functions (funnel.ts, validation.ts) - All SQL queries now scoped by workspace_id - Added date validation via resolveDateRange (returns 400 on invalid) - Routes pass session.workspaceId to analytics functions - Enforced ordered stage progression in funnel paths
- Resolved conflicts with origin/feature/LIN-55-comment-first-mode - Kept ttfv functionality and dateRange tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear Issue
Closes LIN-XXX (or Relates to LIN-XXX)
Changes
Type of Change
Testing
npm run test:unitnpm run test:integrationnpm run test:e2eTest Coverage
Screenshots / Videos
Security Considerations
Documentation
Database Changes
npx prisma migrate dev --name descriptive_nameAPI Changes
Deployment Notes
Pre-PR Checklist
feature/LIN-XXX-descriptionLIN-XXX: Descriptiongit pull origin maindone (no conflicts)npm run lintpassesnpm run typecheckpassesnpm run testpassesconsole.logordebuggerstatementsReviewer Notes
Related PRs
Post-Merge Actions
Screenshots of Changes
By submitting this PR, I confirm that: